Opened 16 years ago
Closed 16 years ago
#235 closed Bug (fixed)
Incorrect sign used when applying empold correction to freshwater budget
Reported by: | acc | Owned by: | nemo |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | OCE | Version: | v3.0 |
Severity: | Keywords: | ||
Cc: |
Description
The correction to the freshwater fluxes estimated from the previous year's budegt is
being applied with the wrong sign in sbcfwb.F90. Lines 127 and 128:
IF( MOD( kt-1, kn_fsbc ) == 0 ) THEN
emp (:,:) = emp (:,:) - empold
emps(:,:) = emps(:,:) - empold
ENDIF
should be:
IF( MOD( kt-1, kn_fsbc ) == 0 ) THEN
emp (:,:) = emp (:,:) + empold
emps(:,:) = emps(:,:) + empold
ENDIF
Note this is for case nn_fwb=2 which corrects the annual global mean based on the
mean ssh change from the previous year. This is incorrectly commented as case nn_fwb=1 in
the namelist and kn_fwb=1 in the header for subroutine sbc_fwb.
Commit History (1)
Changeset | Author | Time | ChangeLog |
---|---|---|---|
1168 | rblod | 2008-08-11T12:21:06+02:00 | Correct a bug in emp and emps sign, correct comments, see ticket #235 |
Change History (1)
comment:1 Changed 16 years ago by rblod
- Resolution set to fixed
- Status changed from new to closed