Opened 9 months ago

Closed 9 months ago

Last modified 9 months ago

#2358 closed Bug (fixed)

bug in dynzdf when ln_drgimp and ln_isfcav

Reported by: mathiot Owned by: mathiot
Priority: low Milestone:
Component: DYN Version: trunk
Severity: minor Keywords:
Cc:

Description

Context

Wrong indexes used for va and zwd in dynzdf with ln_drgimp and ln_isfcav set to .true. .

Analysis

It looks like a copy paste issue. This bug only affect the trunk with ln_drgimp and ln_isfcav set to .true. .

Fix

  • dynzdf.F90

     
    148148                  ze3ua =  ( 1._wp - r_vvl ) * e3u_n(ji,jj,iku) + r_vvl * e3u_a(ji,jj,iku) 
    149149                  ze3va =  ( 1._wp - r_vvl ) * e3v_n(ji,jj,ikv) + r_vvl * e3v_a(ji,jj,ikv) 
    150150                  ua(ji,jj,iku) = ua(ji,jj,iku) + r2dt * 0.5*( rCdU_top(ji+1,jj)+rCdU_top(ji,jj) ) * ua_b(ji,jj) / ze3ua 
    151                   va(ji,jj,ikv) = va(ji,jj,ikv) + r2dt * 0.5*( rCdU_top(ji+1,jj)+rCdU_top(ji,jj) ) * va_b(ji,jj) / ze3va 
     151                  va(ji,jj,ikv) = va(ji,jj,ikv) + r2dt * 0.5*( rCdU_top(ji,jj+1)+rCdU_top(ji,jj) ) * va_b(ji,jj) / ze3va 
    152152               END DO 
    153153            END DO 
    154154         END IF 
     
    427427               DO ji = 2, jpim1 
    428428                  ikv = mikv(ji,jj)       ! (first wet ocean u- and v-points) 
    429429                  ze3va =  ( 1._wp - r_vvl ) * e3v_n(ji,jj,ikv) + r_vvl * e3v_a(ji,jj,ikv)   ! after scale factor at T-point 
    430                   zwd(ji,jj,iku) = zwd(ji,jj,iku) - r2dt * 0.5*( rCdU_top(ji+1,jj)+rCdU_top(ji,jj) ) / ze3va 
     430                  zwd(ji,jj,ikv) = zwd(ji,jj,ikv) - r2dt * 0.5*( rCdU_top(ji,jj+1)+rCdU_top(ji,jj) ) / ze3va 
    431431               END DO 
    432432            END DO 
    433433         ENDIF 

Commit History (2)

ChangesetAuthorTimeChangeLog
12293mathiot2019-12-30T18:13:05+01:00

part of ticket #2358 also affect dev_r11943_MERGE_2019 (option2 seems OK)

12292mathiot2019-12-30T18:07:45+01:00

fix #2358

Change History (2)

comment:1 Changed 9 months ago by mathiot

  • Resolution set to fixed
  • Status changed from new to closed

In 12292:

fix #2358

comment:2 Changed 9 months ago by mathiot

In 12293:

part of ticket #2358 also affect dev_r11943_MERGE_2019 (option2 seems OK)

Note: See TracTickets for help on using tickets.