Opened 4 years ago
Closed 4 years ago
#2497 closed Bug (fixed)
Incorrect time-series output in file tracer.stat when key_iomput is undefined
Reported by: | smueller | Owned by: | smueller |
---|---|---|---|
Priority: | low | Milestone: | |
Component: | TOP | Version: | v4.0.* |
Severity: | minor | Keywords: | tracer |
Cc: |
Description
Context
The file tracer.stat produced by a standard ORCA2_ICE_PISCES run with undefined key_iomput differs from that produced by a corresponding run with defined key_iomput. Further, SETTE reports the failure of the ORCA2_ICE_PISCES restartability test if key_iomput is undefined (e.g., in SETTE with environment variables SETTE_XIOS and SETTE_MPMD set to "no") due to differences in the output file tracer.stat.
Analysis
When time-series output into file tracer.stat is active, local variable ll_trcstat in source:/NEMO/releases/r4.0/r4.0-HEAD/src/TOP/trcstp.F90 is set to .TRUE. during timesteps which compute and output tracer.stat time-series values. In the ORCA2_ICE_PISCES configuration of the model, variable areatot, which is used in the time-series computation, varies in time. Without key_iomput, however, areatot is not updated during all timesteps in which ln_trcstat is set to .TRUE., which leads to the computation of incorrect time-series values. In contrast, if key_iomput is defined and the output of at least one of a set of specific PISCES diagnostic variables (pno3tot, ppo4tot, psiltot, palktot, and pfertot) is enabled, areatot is updated during all timesteps and the tracer.stat time series is correctly computed.
Fix
Line source:/NEMO/releases/r4.0/r4.0-HEAD/src/TOP/trcstp.F90:#L81 could be brought into line with the corresponding trunk version (source:/NEMO/trunk/src/TOP/trcstp.F90@13286:#L83) by substituting ll_trcstat for ln_ctl in order to ensure the correct computation of the tracer.stat time-series values.
Commit History (1)
Changeset | Author | Time | ChangeLog |
---|---|---|---|
13323 | smueller | 2020-07-17T19:08:12+02:00 | Repair of the tracer.stat time-series computation (ticket #2497) |
Change History (3)
comment:1 Changed 4 years ago by smueller
comment:2 Changed 4 years ago by smueller
- Owner changed from systeam to smueller
- Status changed from new to assigned
comment:3 Changed 4 years ago by smueller
- Resolution set to fixed
- Status changed from assigned to closed
source:/NEMO/releases/r4.0/r4.0-HEAD@13323 has passed the standard SETTE tests.
In 13323: