Compiling DOME on ARCHER2 fails

[jamesharle]

Context

When compiling the DOME test case on UK ARCHER2 HPC it fails with the following message:

IMPLICIT NONE is specified in the host scope, therefore an explicit type must be specified for function "MIG0_OLDCMP".

Analysis

It doesn't appear mig0_oldcmp is defined in the code base, but I'm not 100% familiar with this test case. Looking at BENCH for a comparison I presume this variable should be mig0?

Fix

usrdef_hgr.F90

@@ -88 +88 @@
 #endif
       DO_2D( 1, 1, 1, 1 )
-         zti = REAL( mig0_oldcmp(ji) - 1, wp )   ! start at i=0 in the global grid without halos
-         ztj = REAL( mjg0_oldcmp(jj) - 1, wp )   ! start at j=0 in the global grid without halos
+         zti = REAL( mig0(ji) - 1, wp )   ! start at i=0 in the global grid without halos
+         ztj = REAL( mjg0(jj) - 1, wp )   ! start at j=0 in the global grid without halos
          plamt(ji,jj) = rn_dx * 1.e-3 * ( zlam0 + zti )
          plamu(ji,jj) = rn_dx * 1.e-3 * ( zlam0 + zti + 0.5_wp )

[smasson]

Yes, I introduced mig0_oldcmp when we were testing the suppression of the MPI halos from the input/output files. This function was allowing me to get exactly the same results and validate the modifications.
It was a temporary feature and I removed it in [14223].
tests/DOME/MY_SRC/usrdef_hgr.F90 was introduced later at [14254] with this "old" feature.

Note that replacing mig0_oldcmp by mig0 generates a shift of 1. I think that the modifications of DOME should follow what was done in BENCH for example to make sure the generated grid is still centered around the exact same point. see
https://forge.ipsl.jussieu.fr/nemo/changeset/14223/NEMO/trunk/tests/BENCH/MY_SRC/usrdef_hgr.F90

[jchanut]

My mistake. DOME was tested with a trunk version right before Seb changes @1423. I certainly forgot to checkout the code before updating...
An other replacement of mig0_oldcmp can be found here:
https://forge.ipsl.jussieu.fr/nemo/changeset?sfp_email=&sfph_mail=&reponame=&new=14223%40NEMO%2Ftrunk%2Ftests%2FVORTEX%2FMY_SRC%2Fusrdef_hgr.F90&old=13295%40NEMO%2Ftrunk%2Ftests%2FVORTEX%2FMY_SRC%2Fusrdef_hgr.F90

[jchanut]

Repaired @ r14976