Derived data type component name shadowing FORTRAN keyword #mixedprecision

[sparonuz]

Context

In file OCE/ICB/icblbc.f90 is declared the following

   TYPE, PUBLIC :: buffer
      INTEGER :: size = 0
      REAL(wp), DIMENSION(:,:), POINTER ::   data
   END TYPE buffer

Both components have a name that shadows an intrinsic statement.
Specifically

• this intrinsic procedure ​https://gcc.gnu.org/onlinedocs/gfortran/SIZE.html#SIZE and
• this statement ​https://docs.oracle.com/cd/E19957-01/805-4939/6j4m0vn85/index.html

Analysis

Even if the compiler does not complain, it is not a good practice and a possible source of error or confusion. It is also a source of disturbance during the parsing part of the mixed precision implementation's workflow.
Even though the second is a Fortran 77 statement, and in some usage is obsolescent, as explained on page 140 of Modern Fortran Explained (Metcalf, Cohen & Reid) in some cases is still needed:

We recommend using the type declaration statement rather than the data statement, but the data statement must be employed when only part of a variable is to be initialised.

(I mentioned this because the authors are members of the WG5, which is responsible for the development of Fortran)

Recommendation

I would rather change the data type to

   TYPE, PUBLIC :: buffer
      INTEGER :: buffer_size = 0
      REAL(wp), DIMENSION(:,:), POINTER ::   buffer_data
   END TYPE buffer

And coherently in the whole file icblbc.f90 (it is the only file where this DS is used).