Opened 3 years ago
Closed 3 years ago
#2710 closed Bug (fixed)
Sign error in lid melting code in topographic melt pond scheme
| Reported by: | dlivings | Owned by: | systeam |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | SI3 | Version: | |
| Severity: | major | Keywords: | trunk SI3 melt pond |
| Cc: |
Description
There is a sign error in the lid melting code in the topographic melt pond scheme in SI3. In the current version of NEMO/trunk/src/ICE/icethd_pnd.F90 (last changed at [14997]) the error is in line 664. This currently reads
zdvice = MIN( dh_i_sum_2d(ji,jj,jl)*a_ip(ji,jj,jl), v_il(ji,jj,jl) )
but should be
zdvice = MIN( -dh_i_sum_2d(ji,jj,jl)*a_ip(ji,jj,jl), v_il(ji,jj,jl) )
(compare line 597). In the code as currently written, zdvice is always negative or zero, with the result that the test at line 666 always fails and the code that transfers volume from the lid to the pond is never executed. I've confirmed this by adding a statement that writes a log message the first time this piece of code is executed.
Commit History (1)
| Changeset | Author | Time | ChangeLog |
|---|---|---|---|
| 15243 | clem | 2021-09-10T11:52:16+02:00 | trunk: solve ticket #2710 |
Change History (2)
comment:1 Changed 3 years ago by clem
comment:2 Changed 3 years ago by clem
- Resolution set to fixed
- Status changed from new to closed
In 15243: