Opened 12 years ago

Closed 12 years ago

Last modified 3 years ago

#274 closed Bug (fixed)

compiltation issues of the 1D configuration in release v3

Reported by: momme Owned by: ctlod
Priority: normal Milestone:
Component: C1D Version: release-3.0
Severity: Keywords: compilation release-3.0
Cc:

Description

To compile NEMO with the 1D configuration active, one has to apply the following fixes:

in C1D_SRC/step_c1d.F90:

insert:
USE traadv

replace:
USE dyncor1d → USE dyncor_c1d
USE dynnxt1d → USE dynnxt_c1d

in the line:
CALL dyn_vor_c1d( kstp ) ! vorticity term including Coriolis
the subroutine dyn_vor_c1d doesn't exist.
Comparison with v2 suggests that probably this should read:
CALL dyn_cor_c1d( kstp )

in OPA_SRC/ZDF/zdftke.F90:

in the lines:
# if defined key_c1d

hlc(:,:) = zhlc(:,:) * tmask(:,:,1) ! c1d configuration: save finite Langmuir Circulation depth

# endif

hlc has not been declared. As far as I understood this would only serve for diagnostic output so I simply commentet these lines.

Commit History (1)

ChangesetAuthorTimeChangeLog
1221ctlod2008-10-31T14:48:31+01:00

correct compilation errors when using key_c1d cpp key, see ticket: #274

Change History (10)

comment:1 in reply to: ↑ description Changed 12 years ago by ctlod

  • Owner changed from NEMO team to ctlod
  • Status changed from new to assigned

Replying to momme:

To compile NEMO with the 1D configuration active, one has to apply the following fixes:

in C1D_SRC/step_c1d.F90:

insert:
USE traadv

This is not required since the CALL tra_adv which exist into step_1d.F90 must just be removed.

replace:
USE dyncor1d → USE dyncor_c1d
USE dynnxt1d → USE dynnxt_c1d

in the line:
CALL dyn_vor_c1d( kstp ) ! vorticity term including Coriolis
the subroutine dyn_vor_c1d doesn't exist.
Comparison with v2 suggests that probably this should read:
CALL dyn_cor_c1d( kstp )

in OPA_SRC/ZDF/zdftke.F90:

in the lines:
# if defined key_c1d

hlc(:,:) = zhlc(:,:) * tmask(:,:,1) ! c1d configuration: save finite Langmuir Circulation depth

# endif

hlc has not been declared. As far as I understood this would only serve for diagnostic output so I simply commentet these lines.

This will be corrected.

comment:2 Changed 12 years ago by ctlod

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:3 Changed 4 years ago by nicolasmartin

  • Keywords configurations added; configuration removed

comment:4 Changed 4 years ago by nicolasmartin

  • Keywords 1D removed

comment:5 Changed 4 years ago by nicolasmartin

  • Keywords errors removed

comment:6 Changed 4 years ago by nicolasmartin

  • Keywords nemo_v3* added

comment:7 Changed 4 years ago by nicolasmartin

  • Keywords nemo_v3 added; configurations removed

comment:8 Changed 4 years ago by nicolasmartin

  • Milestone NEMO improvements deleted

Milestone NEMO improvements deleted

comment:9 Changed 4 years ago by nicolasmartin

  • Keywords nemo_v3 removed

comment:10 Changed 3 years ago by nemo

  • Keywords release-3.0 added; nemo_v3* removed
Note: See TracTickets for help on using tickets.