Opened 12 years ago

Closed 12 years ago

#292 closed Bug (fixed)

incorrect calculation of icycle in dynspg_ts.F90

Reported by: acc Owned by: nemo
Priority: normal Milestone:
Component: OCE Version: release-3.0
Severity: Keywords:
Cc:

Description

On line 307 of dynspg_ts.F90, icycle is computed as:

icycle = 3 /2 * ibaro

This does not give the intended result due to integer arithmetic and the left
to right precedence of the operators. Consequently the time averaging after
barotropic velocities will be using a running total that is computed over only
half the intended number of timesteps (i.e. icycle = ibaro ).

Can be fixed by setting

icycle = 3 * ibaro / 2

Commit History (1)

ChangesetAuthorTimeChangeLog
1241rblod2009-01-05T17:14:49+01:00

Fix a stupid bug for time splitting and ensure restartability for dynspg_ts in addition, see tickets #280 and #292

Change History (1)

comment:1 Changed 12 years ago by rblod

  • Resolution set to fixed
  • Status changed from new to closed

Fixed, and introduce nn_baro as the integer number of sub time steps, instead of rdtb. By the way, the last version of obcdta is out of date for reading barotropic fields, so for this ticket closed, I have to open a new one…

Note: See TracTickets for help on using tickets.