New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#323 (Bug in sbcssr.F90 when adding a damping term on emp & emps (nn_sssr=2)) – NEMO

Opened 15 years ago

Closed 15 years ago

#323 closed Bug (fixed)

Bug in sbcssr.F90 when adding a damping term on emp & emps (nn_sssr=2)

Reported by: spolod Owned by: nemo
Priority: low Milestone:
Component: OCE Version: v3.0
Severity: Keywords:
Cc:

Description (last modified by ctlod)

Hi

Bug in sbcssr.F90 (SUBROUTINE sbc_ssr( kt ))

In the case nn_sssr == 2, the sss data isn't read as the read of the namelist !

lines 121 and 144 should be:

144	         IF( nn_sssr >= 1)

in both blocks:

    121          IF( nn_sssr == 1 ) THEN      ! set sf_sss structure
    122             !
    123             ALLOCATE( sf_sss(1), STAT=ierror )
    124             IF( ierror > 0 ) THEN
    125                CALL ctl_stop( 'sbc_ssr: unable to allocate sf_sss structure' )   ;   RETURN
    126             ENDIF
    127             ALLOCATE( sf_sss(1)%fnow(jpi,jpj) )
    128             ALLOCATE( sf_sss(1)%fdta(jpi,jpj,2) )
    129 
    130             ! fill sf_sss with sn_sss and control print
    131             CALL fld_fill( sf_sss, (/ sn_sss /), cn_dir, 'sbc_ssr', 'SSS restoring term toward SSS data', 'namsbc_ssr' )
    132 
    133          ENDIF

and

140	      IF( nn_sstr + nn_sssr /= 0 ) THEN
141	
142	         IF( nn_sstr == 1)   CALL fld_read( kt, nn_fsbc, sf_sst )   ! Read SST data and provides it
143	         !                                                          ! at the current time-step
144	         IF( nn_sssr == 1)   CALL fld_read( kt, nn_fsbc, sf_sss )   ! Read SSS data and provides it
145	         !                                                          ! at the current time-step
146	 
147	         !                                         ! ========================= !
148	         IF( MOD( kt-1, nn_fsbc ) == 0 ) THEN      !    Add restoring term     !
149	            !                                      ! ========================= !

Commit History (1)

ChangesetAuthorTimeChangeLog
1294ctlod2009-02-04T17:30:59+01:00

need to read namelist and data to be able to perform sss restoring when nn_sssr=2, see ticket: #323

Change History (1)

comment:1 Changed 15 years ago by ctlod

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.