Opened 11 years ago

Closed 10 years ago

Last modified 3 years ago

#633 closed Bug (fixed)

num_sal hardcoded in limrst.F90

Reported by: dupontf Owned by: gm
Priority: low Milestone:
Component: LIM3 Version: release-3.2
Severity: Keywords: LIM*
Cc:

Description

Hi all,

I found an awkward feature in limrst.F90: num_sal is hardcoded locally to 2 and then salinity is computed for each layer and category, using a local function instead of using the routine lim_var_salprof. I assume that the rationale is the namelist for sea-ice salinity is only read long after in lim_thd. However, this screws off the computation of the first ice temperatures that will be used subsequently in lim_thd_diff. Not necessarily a big bug, just an annoying feature.

The suggested solution is to read call lim_thd_sal_init from ice_init just after the call to ice_run. Then the restart variables are read, and hereafter the already present calls to lim_var_agg and lim_var_glo2eqv will retrieve the correct salinities and therefore temperatures.

The lines in limrst.F90 467 to 501 are then useless.

Fred.

Commit History (2)

ChangesetAuthorTimeChangeLog
2477cetlod2010-12-17T14:42:51+01:00

v3.2:remove hardcoded value of num_sal in limrst.F90, see ticket #633

2475gm2010-12-17T07:45:43+01:00

v3.3beta: #633 LIM-3 correct the hard coded num_sal in limrst + symmetric changes in LIM-2

Change History (5)

comment:1 Changed 11 years ago by smasson

  • Owner changed from NEMO team to smasson

comment:2 Changed 11 years ago by smasson

  • Status changed from new to assigned

comment:3 Changed 10 years ago by gm

  • Owner changed from smasson to gm
  • Status changed from assigned to new

I totally agree with this ticket and the suggested solution.

the call to lim_thd_init and lim_thd_sal_init has been moved in iceini.F90 so that the two namelist namicethd and namicesal are read during the initialisation phase.

To avoid circular dependancy, the variables read in namicesal have been moved from limthd_sal to ice.F90. As a consequence the use of iceini as well as limistate has been suppressed from many modules as they already have a "USE ice"

done in v3.3b see changeset:2475

In LIM-2 similar changes have been done to suppress the "USE iceini" from limrhg

To be done for consolidated v3.2 before closing the ticket

comment:4 Changed 10 years ago by cetlod

  • Resolution set to fixed
  • Status changed from new to closed

Done in v3.2 for consolidation, see changeset:2477

comment:5 Changed 3 years ago by nemo

  • Keywords LIM* added
Note: See TracTickets for help on using tickets.