Opened 11 years ago

Closed 11 years ago

#648 closed Bug (fixed)

missing east and north bmask in obcini

Reported by: dupontf Owned by: nemo
Priority: low Milestone:
Component: OCE Version: release-3.2
Severity: Keywords:
Cc:

Description

This must be very minor, but I have noticed that bmask definitions for east and north boundaries have disappeared from the new NEMO3.2 obcini.F90 (no tag). Is it because they are no longer necessary?

Fred.

Commit History (1)

ChangesetAuthorTimeChangeLog
1813rblod2010-03-25T12:22:36+01:00

Fixes for OBC, see ticket #648

Attachments (1)

obcini.F90 (30.3 KB) - added by molines 11 years ago.
obcini.F90 with bug fix for bmask and nbobc

Download all attachments as: .zip

Change History (5)

comment:1 follow-up: Changed 11 years ago by molines

Hi Fred,

bmask was used only for rigid lid configurations. This option has been removed in nemo_3.2 and thus bmask is not used anymore (anywhere in the code).

Jean-Marc

comment:2 in reply to: ↑ 1 Changed 11 years ago by molines

Replying to molines:

Hi Fred,

bmask was used only for rigid lid configurations. This option has been removed in nemo_3.2 and thus bmask is not used anymore (anywhere in the code).

Jean-Marc

Sorry ! I did a mistake. bmask is still used, in the elliptic solver. The missing bmask correction for North and East boundary is clearly a mistake that should be corrected.

Jean-Marc

Changed 11 years ago by molines

obcini.F90 with bug fix for bmask and nbobc

comment:3 Changed 11 years ago by molines

I attached to this ticket a corrected version for obcini.F90. It fixes :

  • bmask correction for East and North boundaries (mentioned by Fred up there). This in fact was a severe bug that was blowing up the model at the very first step in case of eastern or northern OBC's.
  • in 3.2, nbobc is initialized to nn_nbobc (which is supposed to be a namelist parameter, but which in fact is not ! ) nbobc is just a counter of Open Boundaries, computed within obcini and just used for diagnostic. No reason for nn_nbobc.

Jean-Marc

comment:4 Changed 11 years ago by rblod

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.