Opened 10 years ago

Closed 10 years ago

Last modified 4 years ago

#764 closed Bug (fixed)

sbcfwb: control of option at the wrong place (Pb in MPP)

Reported by: gm Owned by: nemo
Priority: lowest Milestone:
Component: OCE Version: release-3.2
Severity: Keywords: SBC
Cc:

Description

In sbcfwb.F90, a check of the namelist parameter is done inside a IF(lwp). In MPP, the test will be done only on the first processor as lwp=.false. on all other proc.

This concerns both v3.2.1 and v3.3beta.

The following lines:

         IF(lwp) THEN
            WRITE(numout,*)
            WRITE(numout,*) 'sbc_fwb : FreshWater Budget correction'
            WRITE(numout,*) '~~~~~~~'
            IF( kn_fwb == 1 )   WRITE(numout,*) '          instantaneously set to zero'
            IF( kn_fwb == 2 )   WRITE(numout,*) '          adjusted from previous year budget'
            IF( kn_fwb == 3 )   WRITE(numout,*) '          fwf set to zero and spread out over erp area'
            !
            IF( kn_fwb == 3 .AND. nn_sssr /= 2 )   &
               &   CALL ctl_stop( 'The option nn_fwb = 3 must be associated to nn_sssr = 2 ' )
            
         ENDIF

should be changed into:

         IF(lwp) THEN
            WRITE(numout,*)
            WRITE(numout,*) 'sbc_fwb : FreshWater Budget correction'
            WRITE(numout,*) '~~~~~~~'
            IF( kn_fwb == 1 )   WRITE(numout,*) '          instantaneously set to zero'
            IF( kn_fwb == 2 )   WRITE(numout,*) '          adjusted from previous year budget'
            IF( kn_fwb == 3 )   WRITE(numout,*) '          fwf set to zero and spread out over erp area'
         ENDIF
         !
         IF( kn_fwb == 3 .AND. nn_sssr /= 2 )   CALL ctl_stop( 'sbc_fwb: nn_fwb = 3 requires nn_sssr = 2, we stop ' )
         !

Commit History (2)

ChangesetAuthorTimeChangeLog
2471cetlod2010-12-13T14:44:36+01:00

v3.2: put the print control option at the right place, see ticket #764

2438gm2010-11-27T09:55:23+01:00

v3.3beta: #764 correct a trivial bug in sbcfwb + style

Change History (5)

comment:1 Changed 10 years ago by gm

Done in v3.3beta : see changeset:2438

To be done in v3.2.1 for consolidation of the previous release

comment:2 Changed 10 years ago by cetlod

done in v3.2 for consolidation, see changeset:2471

comment:3 Changed 10 years ago by cetlod

  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed 4 years ago by nicolasmartin

  • Milestone 2010 Stream 2: Developer Interfaces deleted

Milestone 2010 Stream 2: Developer Interfaces deleted

comment:5 Changed 4 years ago by nicolasmartin

  • Keywords SBC added; sbcfwb removed
Note: See TracTickets for help on using tickets.