Opened 9 years ago

Closed 9 years ago

#918 closed Bug (fixed)

zdf restart issue

Reported by: charris Owned by: nemo
Priority: low Milestone:
Component: OCE Version: release-3.4
Severity: Keywords:
Cc: hliu Branch review:
MP ready?: Task progress:

Description

I've found that the latest revision of the 3.4beta branch (r3276) won't do exact restarts. I think this is because of the changes in [3259] where avmu/v is now modified in dynzdf_imp. The sequence of calls in step (where tke_rst is called before dyn_zdf)) means that these changes don't get picked up by zdftke on the first time-step after a restart.

I'm not sure if the solution is just to move the tke_rst call, or whether there is a more significant bug here about the way avmu/v are being used / changed.

Thanks,

Chris

Commit History (1)

ChangesetAuthorTimeChangeLog
3278hliu2012-01-27T13:41:30+01:00

keep avmu(v) intact in dynzdf_imp.F90, ref: ticket #918

Change History (3)

comment:1 Changed 9 years ago by hliu

To make it safe for implementation of bottom friction through avmu(v), I am modifying dynzdf_imp.F90 to keep avmu(v) intact before and after calling "dynzdf_imp".

comment:2 Changed 9 years ago by hliu

Modification committed to the trunk. Now avmu(v) are totally intact through "dynzdf_imp.F90". If the restart issue is still there, we need to look for the other reasons, otherwise, this ticket can be closed.

comment:3 Changed 9 years ago by charris

  • Resolution set to fixed
  • Status changed from new to closed

r3288 is OK for restarts for me, so closing this ticket (with the assumption that scientifically this code is still doing the right thing).

Note: See TracTickets for help on using tickets.