Version 10 (modified by nicolasmartin, 3 years ago) (diff)

AGRIF-3_Jerome-vvl: Agrif compatible with vvl


Action AGRIF-3_Jerome-vvl Agrif compatible with vvl
PI(S) Jérôme Chanut


Enable online nesting (i.e. AGRIF) with non-linear free surface (z* coordinate, eventually z~).

  • Ensure correct fluxes at child grid edges from parent level with time varying vertical thicknesses.
  • Ensure correct update of vertical grid at child grid open boundaries.
  • Implement update of vertical scale factors and volume weighted update of tracers.
Dependencies Depends on: -
Target - Expected end 2017:development OK; running OK.
Trac Ticket #1965
SVN branch branches/2017/dev_r8624_AGRIF3_VVL
Previewer(s) Tim Graham
Reviewer(s) Tim Graham
Status Under review

'.' => '/nemo/wiki/2017WP/AGRIF-3_Jerome-vvl'


This section should be completed before starting to develop the code, in order to find agreement on the method beforehand.



Reference manual and web pages updates

Updated on 10/11/2017 10:52:54 by jchanut

Once the PI has completed this section, he should send a mail to the previewer(s) asking them to preview the work within two weeks.


Since the preview step must be completed before the PI starts the coding, the previewer(s) answers are expected to be completed within the two weeks after the PI has sent his request.
For each question, an iterative process should take place between PI and previewer(s) in order to reach a "YES" answer for each of the following questions.

Questions Answer Comment
Does the previewer agree with the proposed methodology?
Does the previewer agree with the proposed flowchart and list of routines to be changed?
Does the previewer agree with the proposed new list of variables, including agreement with coding rules?
Does the previewer agree with the proposed summary of updates in reference manual?
… … …

Updated on 11/23/2017 18:26:08 by jchanut

Once all "YES" have been reached, the PI can start the development into his development branch.


Once the development is done, the PI should complete this section below and ask the reviewers to start their review in the lower section.

Questions Answer Comment
Can this change be shown to produce expected impact? (if option activated)?
Can this change be shown to have a null impact? (if option not activated)
Detailed results of restartability and reproducibility when the option is activated. Please indicate the configuration used for this test
Detailed results of SETTE tests (restartability and reproducibility for each of the reference configuration)
Results of the required bit comparability tests been run: Are there no differences when activating the development?
If some differences appear, is reason for the change valid/understood?
If some differences appear, is the !ticket describing in detail the impact this change will have on model configurations?
Is this change expected to preserve all diagnostics?
If no, is reason for the change valid/understood?
Are there significant changes in run time/memory?
… … …

Updated on 11/24/2020 08:49:28 by anonymous


A successful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November).

Code changes and documentation

Question Answer Comment
Is the proposed methodology now implemented?
Are the code changes in agreement with the flowchart defined at Preview step?
Are the code changes in agreement with list of routines and variables as proposed at Preview step?
If not, are the discrepancies acceptable?
Is the in-line documentation accurate and sufficient?
Do the code changes comply with NEMO coding standards?
Is the !ticket of development documented with sufficient details for others to understand the impact of the change?
Are the reference manual tex files now updated following the proposed summary in preview section?
Is there a need for some documentation on the web pages (in addition to in-line and reference manual)?
If yes, please describe and ask PI. A yes answer must include all documentation available.
… … …

Review Summary

Is the review fully successful?

Updated on 11/24/2020 08:49:28 by anonymous

Once review is successful, the development must be scheduled for merge during next Merge Party Meeting.