Version 5 (modified by gm, 3 years ago) (diff)

ENHANCE-07_Gurvan-Vertical Advection

The PI is responsible to closely follow the progress of the action, and especially to contact NEMO project manager if the delay on preview (or review) are longer than the 2 weeks expected.

Help

The action has to be detailed briefly in the 'Summary' section for later inclusion in other pages.
Edit the 'Summary' section as with an ordinary wiki page.

  • Italic formatting shows the default values or help.
  • Set specific Trac Links (development ticket and branch).

Out of this, the rest of the page can be edited on-line inside the form fields considering the following color code given hereafter.

Role / Color code

PI(S) Previewer(s) Reviewer(s)

Record your modifications for the section you have edited by clicking on the corresponding button at the end of the section with 'Save …' button. Just above, the log record will be updated.

The informations inside the form fields and this wiki page itself are stored in 2 separate databases.
As a consequence, there is absolutely no risk to make any modification in the page itself as long as you don't rename the page or modify the source code of {{{#!TracForm ... }}} processors.

Summary

Action ENHANCE-07_Gurvan-Vertical Advection
PI(S) Gurvan Madec

Digest

Vertical advection scheme : 4th order capability for both tracer and momentum in all context (including ISF case).

  1. adapt the compact 4th order (CPT4) scheme for ISF
  2. CPT4 currently with CEN2 at top & bottom boundary, add a homogeneous Neumann boundary condition (better)
  3. add a CPT5 case smaller CFL but better solution
  4. flux form advection: CPT4 (and 5 ?) on vertical momentum advection
  5. vector form : add an higher order scheme for vertical momentum advection (based on CPT scheme)
  6. SIMPLIFICATION issue: Introduce a generic tridiagonal solver and use it in vertical CPT advection, implicit vertical diffusion, TKE and GLS.
Dependencies Depends on Gurvan's availability
Target Before the 2017 merge party
Trac Ticket #XXXX
SVN branch branches/$YEAR/dev_r{REV}_{WGorINSTITUTE}-{NUM}_{PIS}-{KEYWORDS}
Previewer(s) Names
Reviewer(s) Names
Status Postponed: a preliminary version exists on my lap-top only. Not enough time to finalize the work
Link

'.' => '/nemo/wiki/2017WP/ENHANCE-07_Gurvan-Vertical_Advection'

Abstract

This section should be completed before starting to develop the code, in order to find agreement on the method beforehand.

Description

Implementation

Reference manual and web pages updates

Updated on 11/25/2020 08:33:26 by anonymous

Once the PI has completed this section, he should send a mail to the previewer(s) asking them to preview the work within two weeks.

Preview

Since the preview step must be completed before the PI starts the coding, the previewer(s) answers are expected to be completed within the two weeks after the PI has sent his request.
For each question, an iterative process should take place between PI and previewer(s) in order to reach a "YES" answer for each of the following questions.

Questions Answer Comment
Does the previewer agree with the proposed methodology?
Does the previewer agree with the proposed flowchart and list of routines to be changed?
Does the previewer agree with the proposed new list of variables, including agreement with coding rules?
Does the previewer agree with the proposed summary of updates in reference manual?
… … …

Updated on 11/25/2020 08:33:26 by anonymous

Once all "YES" have been reached, the PI can start the development into his development branch.

Tests

Once the development is done, the PI should complete this section below and ask the reviewers to start their review in the lower section.

Questions Answer Comment
Can this change be shown to produce expected impact? (if option activated)?
Can this change be shown to have a null impact? (if option not activated)
Detailed results of restartability and reproducibility when the option is activated. Please indicate the configuration used for this test
Detailed results of SETTE tests (restartability and reproducibility for each of the reference configuration)
Results of the required bit comparability tests been run: Are there no differences when activating the development?
If some differences appear, is reason for the change valid/understood?
If some differences appear, is the !ticket describing in detail the impact this change will have on model configurations?
Is this change expected to preserve all diagnostics?
If no, is reason for the change valid/understood?
Are there significant changes in run time/memory?
… … …

Updated on 11/25/2020 08:33:26 by anonymous

Review

A successful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November).

Code changes and documentation

Question Answer Comment
Is the proposed methodology now implemented?
Are the code changes in agreement with the flowchart defined at Preview step?
Are the code changes in agreement with list of routines and variables as proposed at Preview step?
If not, are the discrepancies acceptable?
Is the in-line documentation accurate and sufficient?
Do the code changes comply with NEMO coding standards?
Is the !ticket of development documented with sufficient details for others to understand the impact of the change?
Are the reference manual tex files now updated following the proposed summary in preview section?
Is there a need for some documentation on the web pages (in addition to in-line and reference manual)?
If yes, please describe and ask PI. A yes answer must include all documentation available.
… … …

Review Summary

Is the review fully successful?

Updated on 11/25/2020 08:33:26 by anonymous

Once review is successful, the development must be scheduled for merge during next Merge Party Meeting.