Opened 5 years ago

Closed 5 years ago

Last modified 2 years ago

#1392 closed Bug (fixed)

control for asm or z-tilde

Reported by: rblod Owned by: mocavero
Priority: low Milestone: Unscheduled
Component: OCE Version: release-3.6
Severity: Keywords: ASM VVL namelists
Cc:

Description

I just had a quick look so I may be wrong but it seems than application of the increment in step is controlled by namelist values (nam_asminc) whereas this namelist block is read only with key_asminc. It leads to random behavior in my case (Agrif).
Same story with the use of thickness diffusion in sshwzw and traadv (at least) controlled by boolean read only in vvl case.

Commit History (1)

ChangesetAuthorTimeChangeLog
4998mocavero2014-12-22T17:16:45+01:00

bug fix, see ticket #1392

Change History (13)

comment:1 Changed 5 years ago by acc

In the tilde/vvl case this seems to be a result of removing the default values for name list variables from the code. The simplest solution would be to reintroduce them in domvvl.F90, i.e:

   LOGICAL , PUBLIC                                      :: ln_vvl_ztilde             ! ztilde vertical coordinate
   LOGICAL , PUBLIC                                      :: ln_vvl_layer              

becomes

   LOGICAL , PUBLIC                                      :: ln_vvl_ztilde  = .FALSE.          ! ztilde vertical coordinate
   LOGICAL , PUBLIC                                      :: ln_vvl_layer   = .FALSE.           

or if this isn't acceptable then set them explicitly in domain.F90, i.e.:

      IF( lk_vvl )           CALL dom_vvl_init ! Vertical variable mesh

becomes

      IF( lk_vvl )  THEN
         CALL dom_vvl_init                     ! Vertical variable mesh
      ELSE
         ln_vvl_ztilde = .FALSE.   ;   ln_vvl_layer  = .FALSE.
      ENDIF

comment:2 Changed 5 years ago by clevy

  • Owner changed from NEMO team to mocavero ??

comment:3 Changed 5 years ago by mocavero

  • Owner changed from mocavero ?? to mocavero

I'm investigating this.

comment:4 Changed 5 years ago by mocavero

  • Resolution set to fixed
  • Status changed from new to closed

Introduction into the code of the namelist variables default values for both the assimilation increment (asminc.f90) and the vertical coordinates (domvvl.F90).

comment:5 Changed 4 years ago by nicolasmartin

  • Keywords VVL added; vvl removed

comment:6 Changed 4 years ago by nicolasmartin

  • Keywords namelist added; nameslit removed

comment:7 Changed 4 years ago by nicolasmartin

  • Keywords namelists added; namelist removed

comment:8 Changed 4 years ago by nicolasmartin

  • Keywords nemo_v3_6* added

comment:9 Changed 4 years ago by nicolasmartin

  • Keywords ASM added; asminc removed

comment:10 Changed 2 years ago by nemo

  • Keywords Misc. added

comment:11 Changed 2 years ago by nemo

  • Keywords release-3.6* added; nemo_v3_6* removed

comment:12 Changed 2 years ago by nemo

  • Keywords release-3.6* removed

comment:13 Changed 2 years ago by nemo

  • Keywords Misc. removed
Note: See TracTickets for help on using tickets.