Opened 5 years ago
Last modified 4 years ago
#2199 closed Task
AGRIF-03_XXX_small_jpi_jpj — at Initial Version
| Reported by: | smasson | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 2019 WP |
| Component: | AGRIF | Version: | trunk |
| Severity: | minor | Keywords: | |
| Cc: |
Description
Summary
| Action | NST and small jpi or jpj |
|---|---|
| PI(S) | To be decided... |
| Digest | use mi0, mi1, mj0, mj1 in NST routines |
| Dependencies | |
| Branch | NEMO/branches/$YEAR/dev_r{REV}_{ACTION_NAME} |
| Previewer(s) | |
| Reviewer(s) | |
| Wiki | wiki:${YEAR}WP/... |
Abstract
AGRIF is no more working if the mpi subdomain is so small that all boundary conditions cannot be done within the subdomain.
This happen in fact quite easily for the sponge layer...
Description
Contrary to other parts of the code, AGRIF interface for NEMO (NST routines) is using, for example, nbondi, western_side, eastern_side to deal with the presence or for of boundary conditions...
We should use the mi0, mi1, mj0, mj1 arrays do do this in a cleaner way that would in addition work for any size of jpi and jpj (at least until 3)
Implementation
Describe flow chart of the changes in the code.
List the .F90 files and modules to be changed.
Detailed list of new variables (including namelists) to be defined, give for each the chosen name (following coding rules) and definition.
Reference manual and web pages updates
Using part 1 and 2, define the summary of changes to be done in reference manuals (tex files), guide (rst files) and in the content of web pages.
Once the PI has completed this section, he should send a mail to the previewer(s) asking them to preview the work within two weeks.
Commit History (14)
| Changeset | Author | Time | ChangeLog |
|---|---|---|---|
| 12965 | jchanut | 2020-05-25T09:34:57+02:00 | Further nbondi/nbondj removal with AGRIF - results unchanged - forgotten in task #2199 |
| 12123 | jchanut | 2019-12-09T13:55:34+01:00 | |
| 12120 | jchanut | 2019-12-09T12:03:44+01:00 | |
| 11580 | jchanut | 2019-09-20T10:10:54+02:00 | #2199, remove useless boundary data interpolation at domain edges (used previously with 1 ghost cell and near boundary filtering) |
| 11574 | jchanut | 2019-09-19T12:08:31+02:00 | #2222, import changes from dev_r10973_AGRIF-01_jchanut_small_jpi_jpj (i.e. #2199) |
| 11564 | jchanut | 2019-09-18T16:11:52+02:00 | #2199, merged with trunk |
| 11549 | jchanut | 2019-09-16T14:48:51+02:00 | #2199: Take into account masked open boundaries in sponge definition. Output sponge values. |
| 11542 | jchanut | 2019-09-13T15:27:41+02:00 | #2199: 1) Replace TWO_WAY cpp key by namelist flag ln_agrif_2way. 2) Clean agrif_user module. At this stage, code is reproducible in one way mode down to jpi/jpj=3. Issues for small subdomain sizes (e.g. aprox < 7x7) remain in update (i.e. in 2 way mode). Masking of sponge in unconnected areas has to be implemented. -Cette ligne, et les suivantes ci-dessous, seront ignorées-- M src/NST/agrif_all_update.F90 M src/NST/agrif_user.F90 M src/NST/agrif_oce_sponge.F90 M src/NST/agrif_ice_update.F90 M src/NST/agrif_top_update.F90 M src/NST/agrif_oce.F90 M src/NST/agrif_oce_update.F90 M cfgs/SHARED/namelist_ref |
| 11538 | jchanut | 2019-09-12T10:41:02+02:00 | #2199, enforce ln_nnogather=.FALSE. if no periodic conditions. Some issues have been encountered in VORTEX test case. |
| 11244 | jchanut | 2019-07-10T14:58:47+02:00 | #2199, clean old namelist variables |
| 11226 | jchanut | 2019-07-08T14:56:55+02:00 | #2199, remove remaining use of nlcj |
| 11219 | jchanut | 2019-07-05T14:07:17+02:00 | #2199 1) Define aditionnal arrays to correct the time interpolation of barotropic arrays in corners. Since multiple stages in the time interpolation are necessary, overlapping segments in corners give wrong results otherwise (corrects stage 2 in previous commit).. 2) Added subroutine to correct time extrapolated fluxes at bdy in time splitting routine (updates stage 3 in previous commit). 3) Completly remove non-specified open boundary case. Boundares are now exactly set from parent (no more filtering nor extrapolation for outgoing flows). At this stage, use of nbondi, nbondj variables has been completly removed. |
| 11205 | jchanut | 2019-07-02T14:25:46+02:00 | #2199 1) Make sponge independent of sub-domain size. Partially masked open boundary segments are not taken into account anymore. To do so, sponge coefficients should be read in a file for realistic applications (then nesting tools need to be modified accordingly). 2) Replace East-West-North-South barotropic data arrays by a global 2d array. Then apply barotropic open boundary conditions thanks to mi0/mi1, mj0/mj1 indexes. 3) Call AGRIF bdy update one more time in dynspg_ts during extrapolation phase. This removes a dozen lines of code in dynspg_ts routine. |
| 10979 | jchanut | 2019-05-15T10:19:30+02:00 | Relax minimum domain size with AGRIF, #2199 |
