New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#2258 (KERNEL-02_Storkey_Coward_IMMERSE_first_steps) – NEMO

Opened 5 years ago

Closed 4 years ago

#2258 closed Task (fixed)

KERNEL-02_Storkey_Coward_IMMERSE_first_steps

Reported by: davestorkey Owned by: davestorkey
Priority: high Milestone: IMMERSE 2019
Component: DYN Version: trunk
Severity: major Keywords:
Cc: acc

Description (last modified by davestorkey)

BE CAREFUL !!! Due to dynamic behaviour of this ticket creation page, it is highly recommend to set first all other fields before writing the ticket description below.
If you have lost your draft after an unwanted reload, you can click on the link 'Restore Form' in the contextual menu upper right to recover it.
Remove these lines after reading.

Summary

Action KERNEL-02_Storkey_Coward_IMMERSE_first_steps
PI(S) Dave Storkey, Andrew Coward
Digest Rename state variables and introduce DO loop macros
Dependencies
Branch NEMO/branches/$YEAR/dev_r{REV}_{ACTION_NAME}
Previewer(s)
Reviewer(s)
Wiki wiki:2019WP/KERNEL-02_Storkey_Coward_IMMERSE_first_steps

Abstract

This section should be completed before starting to develop the code, in order to find agreement with the previewer(s) on the method beforehand.

Description

Describe the goal of development, and the methodology.
Add reference documents or publications if relevant.

Implementation

Describe flow chart of the changes in the code.
List the .F90 files and modules to be changed.
Detailed list of new variables (including namelists) to be defined, give for each the chosen name (following coding rules) and definition.

Reference manual and web pages updates

Using part 1 and 2, define the summary of changes to be done in reference manuals (tex files), guide (rst files) and in the content of web pages.

Once the PI has completed this section, he should send a mail to the previewer(s) asking them to preview the work within two weeks.

Commit History (1)

ChangesetAuthorTimeChangeLog
10740davestorkey2019-03-12T11:29:59+01:00

ticket #2258

Change History (5)

comment:1 Changed 5 years ago by davestorkey

  • Description modified (diff)

comment:2 Changed 5 years ago by davestorkey

In 10740:

Error: Failed to load processor CommitTicketReference
No macro or processor named 'CommitTicketReference' found

comment:3 Changed 5 years ago by davestorkey

Update 5/9/2019

Three tasks are specified on the wiki page:

  1. State variables to be renamed with an extra time dimension and time level swapping achieved by swapping time level indices.
  2. Prognostic fields to be passed to tendency routines from stp as arguments.
  3. Introduction of DO loop macros in preparation for the implementation of tiling.

The first two of these are completed (a small amount of tidying up to do) and ready for the Merge Party in December. The third task (the DO loop macros) is not started and is unlikely to be ready for the Merge Party.

Some thought needs to be given as to how to merge this branch, which touches every part of the code, with other development branches. I think the easiest way will be to merge this branch into the trunk first and then merge in other development branches. There is a python script to implement the renaming of state variables in an "intelligent" way, which should help with this process.

comment:4 Changed 5 years ago by acc

  • wp_comment set to * State variables to be renamed with an extra time dimension and time level swapping achieved by swapping time level indices. [done] * Prognostic fields to be passed to tendency routines from stp as arguments. [done] * Introduction of DO loop macros in preparation for the implementation of tiling [not started and is unlikely to be ready this year]

comment:5 Changed 4 years ago by acc

  • branch_review changed from failed to passed
  • mp_status changed from no to yes
  • Resolution set to fixed
  • Status changed from new to closed

This branch formed the basis of the 2019/dev_r11943_MERGE_2019 merge branch (option 1) into which all other merge-ready branches for 2019 were merged. Activity on this branch has now ceased following successful SETTE testing of 2019/dev_r11943_MERGE_2019.

Note: See TracTickets for help on using tickets.