Opened 4 weeks ago

#2534 new Defect

Extra halo rows in GYRE

Reported by: hadcv Owned by: hadcv
Priority: low Milestone: Documentation
Component: USR Version: trunk
Severity: minor Keywords: GYRE
Cc:

Description

GYRE includes hard-coded halo rows, see usrdef_nam.F90:

kpi = 30 * nn_GYRE + 2       !                     
kpj = 20 * nn_GYRE + 2

and usrdef_hgr.F90:

zlam0 = zlam1 + zcos_alpha * ze1deg * REAL( Ni0glo - 2, wp )
zphi0 = zphi1 + zsin_alpha * ze1deg * REAL( Nj0glo - 2, wp )

Although a trivial issue, the code and documentation now differ:

! usrdef_nam.F90
Ni0glo = 30 * nn_GYRE + 2                 
Nj0glo = 20 * nn_GYRE + 2

! mppini.F90
jpiglo = Ni0glo + 2 * nn_hls
jpjglo = Nj0glo + 2 * nn_hls

! Documentation
jpiglo = 30 * nn_GYRE + 2                 
jpjglo = 20 * nn_GYRE + 2

Recommendation

Remove these halo points from usrdef_nam.F90:

- kpi = 30 * nn_GYRE + 2       !                     
- kpj = 20 * nn_GYRE + 2
+ kpi = 30 * nn_GYRE       !                     
+ kpj = 20 * nn_GYRE 

and usrdef_hgr.F90:

- zlam0 = zlam1 + zcos_alpha * ze1deg * REAL( Ni0glo - 2, wp )
- zphi0 = zphi1 + zsin_alpha * ze1deg * REAL( Nj0glo - 2, wp )
+ zlam0 = zlam1 + zcos_alpha * ze1deg * REAL( Ni0glo, wp )
+ zphi0 = zphi1 + zsin_alpha * ze1deg * REAL( Nj0glo, wp )

and update the documentation:

jpiglo = 30 * nn_GYRE + 2 * nn_hls
jpjglo = 20 * nn_GYRE + 2 * nn_hls

Commit History (0)

(No commits)

Change History (0)

Note: See TracTickets for help on using tickets.