Opened 2 months ago

Closed 2 months ago

#2568 closed Defect (fixed)

Bug in set_namelist in all_functions.sh in SETTE

Reported by: dford Owned by: ayoung
Priority: low Milestone:
Component: MULTIPLE Version: trunk
Severity: minor Keywords:
Cc: Branch review: failed
MP ready?: no Task progress: Unspecified

Description (last modified by dford)

On line 249 of all_functions.sh (https://forge.ipsl.jussieu.fr/nemo/browser/utils/CI/sette/all_functions.sh#L249), if it can’t find the relevant namelist group in namelist_cfg, but does in namelist_ref, it adds that group to the end of namelist_cfg with the lines:

echo "&${NAMGRP}" >> ${EXE_DIR}/$1
echo "/" >> ${EXE_DIR}/$1

There’s two issues with the first of those lines. First, NAMGRP already contains an &, so it’s adding e.g. &&namobs rather than &namobs. Second, on line 255 it searches for the right group with “${NAMGRP} “, i.e. with a space at the end. This space hasn’t been added, so it can’t find the namelist group and doesn’t add the variables it should (but doesn’t throw an error).

This can be solved by changing line 249 to:

echo "${NAMGRP} " >> ${EXE_DIR}/$1

I’ve tested this, and it seems to work. Looking through the SETTE output, I think it’s only namobs and nam_asminc which are affected by this, which are just tested in ORCA2_ICE_OBS_ST.

Commit History (1)

ChangesetAuthorTimeChangeLog
13788ayoung2020-11-13T10:11:55+01:00

Removing extra ampersand from namelist group. Fixing bug in ticket #2568.

Change History (5)

comment:1 Changed 2 months ago by dford

  • Description modified (diff)

comment:2 Changed 2 months ago by ayoung

  • Owner changed from systeam to ayoung
  • Status changed from new to assigned

comment:3 Changed 2 months ago by ayoung

In 13788:

Removing extra ampersand from namelist group. Fixing bug in ticket #2568.

comment:4 Changed 2 months ago by ayoung

Bug is now fixed - no change in sette test results.

Current code is : URL: https://forge.ipsl.jussieu.fr/nemo/svn/NEMO/trunk @ r13785 ( last change @ r13747 )

SETTE validation report generated for :

URL: https://forge.ipsl.jussieu.fr/nemo/svn/NEMO/trunk @ r13747 (last changed revision)

on XC40_METO_IFORT arch file

!!———————-1st pass—————————!!

!——restart——!

WGYRE_PISCES_ST run.stat restartability passed : 13747
WGYRE_PISCES_ST tracer.stat restartability passed : 13747
WORCA2_ICE_PISCES_ST run.stat restartability passed : 13747
WORCA2_ICE_PISCES_ST tracer.stat restartability passed : 13747
WORCA2_OFF_PISCES_ST tracer.stat restartability passed : 13747
WAMM12_ST run.stat restartability passed : 13747
WORCA2_SAS_ICE_ST run.stat restartability passed : 13747
WAGRIF_DEMO_ST run.stat restartability passed : 13747
WWED025_ST run.stat restartability passed : 13747
WISOMIP+_ST run.stat restartability passed : 13747
WOVERFLOW_ST run.stat restartability passed : 13747
WLOCK_EXCHANGE_ST run.stat restartability passed : 13747
WVORTEX_ST run.stat restartability passed : 13747
WICE_AGRIF_ST run.stat restartability passed : 13747

!——repro——!

WGYRE_PISCES_ST run.stat reproducibility passed : 13747
WGYRE_PISCES_ST tracer.stat reproducibility passed : 13747
WORCA2_ICE_PISCES_ST run.stat reproducibility passed : 13747
WORCA2_ICE_PISCES_ST tracer.stat reproducibility passed : 13747
WORCA2_OFF_PISCES_ST tracer.stat reproducibility passed : 13747
WAMM12_ST run.stat reproducibility passed : 13747
WORCA2_SAS_ICE_ST run.stat reproducibility passed : 13747
WORCA2_ICE_OBS_ST run.stat reproducibility passed : 13747
WAGRIF_DEMO_ST run.stat reproducibility passed : 13747
WWED025_ST run.stat reproducibility passed : 13747
WISOMIP+_ST run.stat reproducibility passed : 13747
WVORTEX_ST run.stat reproducibility passed : 13747
WICE_AGRIF_ST run.stat reproducibility passed : 13747

!——agrif check——!

ORCA2 AGRIF vs ORCA2 NOAGRIF run.stat unchanged - passed : 13747 13747

!——result comparison check——!

check result differences between :
VALID directory : /scratch/d00/ayoung/testing/http_trunk/NEMO_VALIDATION at rev 13747
and
REFERENCE directory : /scratch/d00/ayoung/testing/http_trunk_ref/NEMO_VALIDATION at rev 13747

WGYRE_PISCES_ST run.stat files are identical
WGYRE_PISCES_ST tracer.stat files are identical
WORCA2_ICE_PISCES_ST run.stat files are identical
WORCA2_ICE_PISCES_ST tracer.stat files are identical
WORCA2_OFF_PISCES_ST tracer.stat files are identical
WAMM12_ST run.stat files are identical
WORCA2_SAS_ICE_ST run.stat files are identical
WAGRIF_DEMO_ST run.stat files are identical
WWED025_ST run.stat files are identical
WISOMIP+_ST run.stat files are identical
WVORTEX_ST run.stat files are identical
WICE_AGRIF_ST run.stat files are identical
WOVERFLOW_ST run.stat files are identical
WLOCK_EXCHANGE_ST run.stat files are identical

comment:5 Changed 2 months ago by ayoung

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.