Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#2569 closed Bug (fixed)

cpp keys not correctly modified by SETTE

Reported by: gsamson Owned by: gsamson
Priority: low Milestone:
Component: tools Version: trunk
Severity: minor Keywords: SETTE,
Cc: Branch review: failed
MP ready?: no Task progress: Unspecified

Description

Context

when changing USING_XIOS and ADD_NOSIGNEDZERO variables values in param.cfg, these modifications are not always taken into account in SETTE simulations.

Analysis

as it is coded now in sette_reference-configurations.sh and sette_test-cases.sh, we can only delete the "key_iomput" cpp key and add the "key_nosignedzero" cpp key, but it is not possible to add the first one and remove the second one.

Fix

update both ADD_KEYS and DEL_KEYS variables when modifying cpp keys to correctly compile nemo with makenemo add_key / del_key options

Commit History (1)

ChangesetAuthorTimeChangeLog
13784gsamson2020-11-12T10:29:29+01:00

correctly handle add/del cpp keys with sette; tiket #2569

Change History (4)

comment:1 Changed 2 months ago by gsamson

In 13784:

correctly handle add/del cpp keys with sette; tiket #2569

comment:2 follow-up: Changed 2 months ago by smasson

Nothing really to do but :

  • Note that key_nosignedzero is related to the compiler you use and not to the configuration itself. That's why for some time now, we (at least I) move it to the arch files of the machines that need it (basically when using gcc) and removed it from the cpp_*.fcm files.
  • Note also that we should do the same with key_mpp_mpi. This is realted to teh way you compile the code (for example ifort or mpif90) and not to the configuration. To me, this cpp key should also be moved to the arch files compiling with mpi…

comment:3 Changed 2 months ago by gsamson

  • Resolution set to fixed
  • Status changed from new to closed

comment:4 in reply to: ↑ 2 Changed 2 months ago by gsamson

Replying to smasson:
I agree with your 2 points, but it implies to change all archfiles and all cpp_cfg.fcm files accordingly. When is the good timing to do that kind of modification ?

Note: See TracTickets for help on using tickets.