Wave coupling only: diurnal cycle reconstruction error

[jcastill]

Context

When running in coupled mode but not coupling to an atmospheric model, and when using diurnal cycle reconstruction (ln_dm2dc=.true.), NEMO will stop with an error:

sbc_cpl_rcv: diurnal cycle reconstruction (ln_dm2dc) needs daily couping for solar radiation

Analysis

Here NEMO still assumes that when it is running in coupled mode it is coupled to an atmosphere model. In coupling mode the diurnal cycle frequency (ncpl_qsr_frq) is calculated as the sum of the coupling frequency of the atmospheric radiation terms, and this value is required to be equal to one day. If there is no atmospheric coupling, which is something perfectly valid to do (for example when coupling only to a wave model), this frequency is equal to zero and the code throws an error.

Recommendation

Throw the error mentioned above only if the frequency is not equal to one day and if atmosphere coupling is taking place (ln_cpl=.true.)

[jcastill]

In 15534:

Error: Failed to load processor CommitTicketReference

No macro or processor named 'CommitTicketReference' found

[jcastill]

Working branch: branches/UKMO/v15531_wave_radiation_diurnal_cycle

I did not find Enda's user name and therefore he is not in copy of the ticket.

[jcastill]

sette.out

[jcastill]

Sette test successfully run. Functionality has been tested in the Met Office amm15 configuration.