New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#2752 (Undefined variable in timing.F90) – NEMO

Opened 2 years ago

Last modified 2 years ago

#2752 assigned Bug

Undefined variable in timing.F90

Reported by: emmafiedler Owned by: systeam
Priority: low Milestone:
Component: MULTIPLE Version: v4.0.*
Severity: minor Keywords:
Cc: emmafiedler, davestorkey

Description

Context

zperc is undefined in src/OCE/timing.F90 when ztot == 0

Analysis

This is unlikely to be of particular importance but causes a compiler error when using debugging flags.

Fix

Initialise zperc to 0 to avoid this issue

Commit History (1)

ChangesetAuthorTimeChangeLog
15599emmafiedler2021-12-14T17:07:32+01:00

Bug fix: initialise zperc to avoid being uninitialised when ztot==0, ticket #2752

Change History (5)

comment:1 Changed 2 years ago by emmafiedler

  • Cc davestorkey added

Initialised zperc to 0, see change in branch here:

​http://forge.ipsl.jussieu.fr/nemo/changeset?sfp_email=&sfph_mail=&reponame=&new=15598%40NEMO%2Fbranches%2FUKMO%2Ftimings_bugfix&old=15596%40NEMO%2Freleases%2Fr4.0%2Fr4.0-HEAD

Dave, please could you review and let me know if it's ok to commit?

Thanks,
Emma

comment:2 Changed 2 years ago by emmafiedler

I should add I've tested with this change and it fixes the compiler error, and the code runs without issue.

comment:3 Changed 2 years ago by davestorkey

Looks OK to me.

comment:4 Changed 2 years ago by emmafiedler

In 15599:

Error: Failed to load processor CommitTicketReference
No macro or processor named 'CommitTicketReference' found

This is in r4.0-HEAD

Last edited 2 years ago by emmafiedler (previous) (diff)

comment:5 Changed 2 years ago by nemo

  • Owner set to systeam
  • Status changed from new to assigned
Note: See TracTickets for help on using tickets.