New URL for NEMO forge!   http://forge.nemo-ocean.eu

Since March 2022 along with NEMO 4.2 release, the code development moved to a self-hosted GitLab.
This present forge is now archived and remained online for history.
#2753 ("ztime" value shifted by one time step in diaharm.F90) – NEMO

Opened 2 years ago

#2753 new Defect

"ztime" value shifted by one time step in diaharm.F90

Reported by: nicolas_gonzalez Owned by: systeam
Priority: low Milestone:
Component: DIA Version: v4.0.*
Severity: minor Keywords: diaharm
Cc: jchanut@…

Description

Context

The tidal phase estimated by diaharm routine is shifted by one time step.

Analysis

The time variable "ztime" at L.183 in the dia_harm subroutine is not consistent with the surface elevation and velocity variables used. It is defined as "ztime = (kt-nit000+1) * rdt" corresponding to "after" time step, however, it is used with the "now" time step sea surface elevation and velocity variables (L.194-196).

Recommendation

Replace the L.183 of diaharm.F90 by the following:

ztime = (kt-nit000) * rdt

Commit History (0)

(No commits)

Change History (0)

Note: See TracTickets for help on using tickets.