Opened 10 years ago

Closed 10 years ago

#688 closed Bug (fixed)

OBC + AGRIF in nemo_v3_2_1: requires fixes

Reported by: molines Owned by: nemo
Priority: high Milestone:
Component: OCE Version: release-3.2
Severity: Keywords:
Cc:

Description

Hello !

As mentioned by Rachid in his mail presenting nemo_v3_2_1, mixing OBC and AGRIF is supported in this release. I should say 'almost' because there are still some fixes to do.

In this ticket I describe the 5 fixes that I found necessary:

  1. obc_par.F90 : PARAMETER attribute should be restored for smooth compilation …
  2. obcdta.F90 : I suggest to use the directives AGRIF_DO_NOT_TREAT to skip the definition of zjcnes_obc, ztobc. It works and looks better than the actual workaround.
  3. agrif_user.F90 : In this module lk_obc (and lk_bdy !) is set to false for the child grid. It is a very good idea that greatly simplify the code, but this should be done before the call to opa_init (hence obc_ini).
  4. solmat.F90 : In the OBC test, I think that in the actual version, the case OBC + child grid is not treated.
  5. traqsr.F90 : The use of agrif directives AGRIF_DO_NOT_TREAT is required to skip some arrays definition.

I have attached the 5 modified modules.

There are 2 other bugs in obc but not linked with agrif and described in next ticket !

Jean-Marc

Commit History (3)

ChangesetAuthorTimeChangeLog
2515smasson2010-12-23T17:08:58+01:00

trunk: bugfix for agrif when using Chlorophyll data, introduced in ticket #688

2514smasson2010-12-23T17:06:35+01:00

v33b: bugfix for agrif when using Chlorophyll data, introduced in ticket #688

2031rblod2010-07-29T14:31:53+02:00

Fix issues with OBC and AGRIF, see ticket #688 and #692

Attachments (5)

obc_par.F90 (5.4 KB) - added by molines 10 years ago.
agrif_user.F90 (18.9 KB) - added by molines 10 years ago.
obcdta.F90 (57.8 KB) - added by molines 10 years ago.
solmat.F90 (15.5 KB) - added by molines 10 years ago.
traqsr.F90 (22.0 KB) - added by molines 10 years ago.

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by molines

Changed 10 years ago by molines

Changed 10 years ago by molines

Changed 10 years ago by molines

Changed 10 years ago by molines

comment:1 Changed 10 years ago by rblod

  • Resolution set to fixed
  • Status changed from new to closed
  • Version changed from nemo_v3_2 to nemo_v3_2_1
Note: See TracTickets for help on using tickets.