#912 closed Bug (fixed)
diaptr_init and timing
| Reported by: | rblod | Owned by: | nemo |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | OCE | Version: | v3.3 |
| Severity: | Keywords: | DIA SAS timing | |
| Cc: |
Description
Very minor. In diaptr_init, there is a kind of wild RETURN if ln_diaptr is false. Then:
- somme useless arrays are allocated if ln_diaptr is flase
- there are side effects on the timing since the timing section is never closed
One easy fix is to put a big IF( ln_diaptr) instead, another way to do could be to have a master namelist for diagnostic to define the set of diagnostic (ln_diaptr, ln_diahsb), and then specific diagnostic namelist to read or not.
Commit History (2)
| Changeset | Author | Time | ChangeLog |
|---|---|---|---|
| 3643 | rblod | 2012-11-23T19:25:00+01:00 |
|
| 3281 | rblod | 2012-01-27T14:06:42+01:00 | Fix diaptr_init see ticket #912 |
Change History (5)
comment:1 Changed 11 years ago by rblod
- Keywords dia_wri_state added
comment:2 Changed 11 years ago by rblod
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed 8 years ago by nicolasmartin
- Milestone 2012 Stream 1: User Interfaces deleted
Milestone 2012 Stream 1: User Interfaces deleted
comment:4 Changed 8 years ago by nicolasmartin
- Keywords DIA added; diaptr removed
comment:5 Changed 8 years ago by nicolasmartin
- Keywords SAS added; dia_wri_state removed
Note: See
TracTickets for help on using
tickets.
THe same kind of thing appends in dia_wri_state where we try to write some timing but without initialisation. The easier fix is to avoid timing this routine since it's not very usefull